[Webkit-unassigned] [Bug 181825] New: [GTK] USE_UPOWER causes crashes inside a chroot or on systems with broken dbus/upower

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181825

            Bug ID: 181825
           Summary: [GTK] USE_UPOWER causes crashes inside a chroot or on
                    systems with broken dbus/upower
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org, gns at gnome.org
            Blocks: 177810

I'm trying to run the GTK layout tests inside a chroot  and I get a lot of test crashing.

Hunting this down it seem it happens only when USE_UPOWER is set.

The problem seems to be that on the constructor of LowPowerModeNotifier at Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp the call to up_client_get_display_device() is returning NULL ( which is ok according to the doc https://upower.freedesktop.org/docs/UPower-up-client.html#up-client-get-display-device ) so we end calling g_signal_connect_swapped with NULL and everything blows up.

Also up_client_new() can as well return NULL according to the doc.

Actually in my test case both are returning NULL, so both m_device and m_upClient are nullptr.

I think we need to check at run-time this, and bail out properly in case something is wrong.

Having UPOWER support at build time doesn't means that it will be functional at run-time.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=177810
[Bug 177810] [GLib] Let WebCore know of low power situations
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180119/cab0b2fc/attachment.html>