[Webkit-unassigned] [Bug 181804] Expose Safe Browsing SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181804

--- Comment #7 from Zach Li <zacharyli323 at gmail.com> ---
(In reply to Alex Christensen from comment #4)
> Comment on attachment 331644 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331644&action=review
> 
> >>> Source/WebKit/Configurations/WebKit.xcconfig:94
> >>> +WK_SAFE_BROWSING_LDFLAGS[sdk=macosx10.12*] = ;
> >> 
> >> If we do want to do this differently for different operating system versions, I think it will need to use $(TARGET_MAC_OS_X_VERSION_MAJOR) like we do above.  I'm not sure if this works.  Also, why don't we just link on all operating systems?
> > 
> > We could link against SafariSafeBrowsing framework on all operating systems we support, but we will only use Safe Browsing pieces on High Sierra and iOS 11 and above because the symbols were introduced then. This will use the SDK version that comes with Xcode, so it will behave differently based on the SDK version. Is that not ideal?
> 
> I'm not sure.  I'm interested in what Dan thinks about this.  I don't know
> this syntax or best practices well.
> 
> > Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h:28
> > +#pragma once
> 
> I think pragma once needs to be first.

Sure.

> 
> > Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h:73
> > +#endif // not USE(APPLE_INTERNAL_SDK)
> 
> not should be removed

Should it? Because this #endif is closer to the else statement which is when we are not using Apple internal SDK. But if this is the style WebKit uses, I will follow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180118/8a920b07/attachment.html>