[Webkit-unassigned] [Bug 181714] New: Generated bindings for derived dictionaries are not regenerated when the base dictionary changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 16 19:42:18 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181714

            Bug ID: 181714
           Summary: Generated bindings for derived dictionaries are not
                    regenerated when the base dictionary changes
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Bindings
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aestes at apple.com
                CC: cdumez at apple.com, sam at webkit.org, youennf at gmail.com

Consider the following two IDL files:

Base.idl:
    dictionary Base {
        unsigned long baseField;
    }

Derived.idl
    dictionary Derived : Base {
        unsigned long derivedField;
    }

When JSDerived.cpp is generated, its convertDictionary() implementation contains the code to convert both baseField and derivedField. JSBase.cpp's convertDictionary() has its own convertDictionary() to convert baseField, but JSDerived.cpp does not rely on it.

If I add a second field to Base.idl and rebuild, JSBase.cpp is updated to convert the new field, but JSDerived.cpp is not updated, so it still only converts the original two fields.

It seems like JSDerived.cpp's convertDictionary() should be calling JSBase.cpp's convertDictionary() to convert the base class fields. Either that or the bindings generator should be regenerating all dictionaries that inherit from Base.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180117/fcc6d8b9/attachment.html>


More information about the webkit-unassigned mailing list