[Webkit-unassigned] [Bug 181683] New: PAL should link to JavaScriptCore rather than WTF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 16 08:03:36 PST 2018


            Bug ID: 181683
           Summary: PAL should link to JavaScriptCore rather than WTF
           Product: WebKit
           Version: Other
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: annulen at yandex.ru, don.olmstead at sony.com,
                    mmaxfield at apple.com

Currently we are accidentally linking WTF into both libjavascriptcoregtk and libwebkit2gtk, which could in theory cause problems similar to bug #179914. There are only two possible solutions:

 * Ensure WTF always built as a shared library if JavaScriptCore is built as a shared library
 * Change PAL to link to JavaScriptCore instead of WTF

The problem here is caused by layer hopping. It can never be a problem if each library only links to the next lowest-layered library.

The downside is this allows PAL to use JavaScriptCore symbols, which is not super desirable. I came up with a hack yesterday for PAL to link to WTF usually, but link to JavaScriptCore instead if ${JavaScriptCore_LIBRARY_TYPE} MATCHES "SHARED" AND ${WTF_LIBRARY_TYPE} MATCHES "STATIC". But that is getting too complex and introduces more possibility for platform-dependent build failures. Better to just accept that PAL will depend on JavaScriptCore.

Note: I'm not brave enough to update the XCode build. We can use that to enforce that no JavaScriptCore symbols actually get used, I guess.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180116/98367d47/attachment-0001.html>

More information about the webkit-unassigned mailing list