[Webkit-unassigned] [Bug 180029] MathML Lengths should take zoom level into account

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 13 02:56:16 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=180029

--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 331279
  --> https://bugs.webkit.org/attachment.cgi?id=331279
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331279&action=review

>>> LayoutTests/ChangeLog:10
>>> +        * mathml/presentation/mspace-units-expected.html: Remove the call to setPageZoomFactor().
>> 
>> mspace-units does not have setPageZoomFactor() and I believe the test should actually *not* be modified as it is not affected by this patch (and please don't do whitespace only change as that makes the history more complicated).
> 
> Oops! I mistook the file you provided on this page with the one we have in the repository.
> 
> Note that the old test does not check the unit "mu". I agree you with that a significant change to whitespace is not history-friendly, something I have not thought of before. So I will submit a separate patch to amend that test later. For this patch, I will only include the new mspace-units-with-zoom.
> 
> And yes, other than the CSS property "zoom" and the check for "mu", there is nothing new.

OK, I did not notice your addition of "mu" (that's another reason not to do whitespace-only changes as that makes review much harder). Note that "mu" is not a CSS property nor a MathML unit. It's just an internal property based on LaTeX to represent MathML's namedspace (see Source/WebCore/mathml/MathMLElement.h). So I don't think you need to test it but if you really want to, you should use namespaces like "verythickmathspace" not "mu".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180113/f61ecb05/attachment.html>


More information about the webkit-unassigned mailing list