[Webkit-unassigned] [Bug 180029] MathML Lengths should take zoom level into account

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 13 02:22:10 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=180029

Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331279|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #4 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 331279
  --> https://bugs.webkit.org/attachment.cgi?id=331279
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331279&action=review

> LayoutTests/ChangeLog:10
> +        * mathml/presentation/mspace-units-expected.html: Remove the call to setPageZoomFactor().

mspace-units does not have setPageZoomFactor() and I believe the test should actually *not* be modified as it is not affected by this patch (and please don't do whitespace only change as that makes the history more complicated).

> LayoutTests/mathml/presentation/mspace-units-with-zoom-expected.html:8
> +    }

That's interesting and seems better than using window.internals. It's the only difference you make with respect to the mspace-units.html test, right?

> Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:173
> +

Mmh, that seems complicated. Why don't you just do "* style.effectiveZoom()" in the 6 cases below? That would make things more readable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180113/fbb7c6e2/attachment.html>


More information about the webkit-unassigned mailing list