[Webkit-unassigned] [Bug 180928] [EME] Add layout test for clearKey CENC message event

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 9 03:36:06 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=180928

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330805|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 330805
  --> https://bugs.webkit.org/attachment.cgi?id=330805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330805&action=review

Most important part is removing the [ Pass ] from the WPE expectations.

Now, I'd encourage you to use more const and let instead of var. I see you have converted many var into let but some of them can be const and there are some var left.

> LayoutTests/platform/wpe/TestExpectations:1003
> +media/encrypted-media/clearKey/clearKey-message-cenc-event.html [ Pass ]
> +media/encrypted-media/clearKey/clearKey-message-cenc-event-mse.html [ Pass ]
> +

This is not needed since we are not skipping globally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180109/073f39ca/attachment.html>


More information about the webkit-unassigned mailing list