[Webkit-unassigned] [Bug 181315] ::first-letter incorrectly selects grapheme pairs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 8 22:46:44 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181315

--- Comment #44 from Darin Adler <darin at apple.com> ---
Comment on attachment 330778
  --> https://bugs.webkit.org/attachment.cgi?id=330778
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330778&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:101
>      return isSpaceOrNewline(c) || c == noBreakSpace || isPunctuationForFirstLetter(c);

Oops, I just spotted a bug here!

The isSpaceOrNewline function takes a UChar, not a UChar32, so calling it will chop off the low 16 bits of "c" and possibly return true when the character is not a space or newline. The fix is to change isSpaceOrNewline to take a UChar32.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180109/cf43075a/attachment.html>


More information about the webkit-unassigned mailing list