[Webkit-unassigned] [Bug 174816] [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174816

--- Comment #17 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 330687
  --> https://bugs.webkit.org/attachment.cgi?id=330687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330687&action=review

Isn't this what WebCore::userVisibleString() does? Can't we implement that in WebCore instead? or even make the current objc implementation cross-platform?

> Source/WebKit/UIProcess/API/glib/WebKitURIUtilities.cpp:47
> +static const UIDNA* internationalDomainNameTranscoder()
> +{
> +    static UIDNA* transcoder;
> +    static std::once_flag onceFlag;
> +    std::call_once(onceFlag, [] {
> +        UErrorCode error = U_ZERO_ERROR;
> +        // These flags should be synced with URLParser::internationalDomainNameTranscoder() in URLParser.cpp.
> +        transcoder = uidna_openUTS46(UIDNA_CHECK_BIDI | UIDNA_CHECK_CONTEXTJ | UIDNA_NONTRANSITIONAL_TO_UNICODE | UIDNA_NONTRANSITIONAL_TO_ASCII, &error);
> +        RELEASE_ASSERT(U_SUCCESS(error));
> +        RELEASE_ASSERT(transcoder);
> +    });
> +    return transcoder;
> +}

Why are we duplicating this? Can't we just use URLParser::internationalDomainNameTranscoder()?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180108/fdc152cd/attachment.html>