[Webkit-unassigned] [Bug 181315] ::first-letter incorrectly selects grapheme pairs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 5 22:35:35 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181315

--- Comment #20 from Chris Nardi <christopherncarmel at hotmail.com> ---
Comment on attachment 330557
  --> https://bugs.webkit.org/attachment.cgi?id=330557
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330557&action=review

>> Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:225
>> +        length += U16_LENGTH(oldText.characterStartingAt(length));
> 
> Are we sure this is going to work? What if the first character is a combining sequence like U+0065 LATIN SMALL LETTER E followed by U+0300 COMBINING GRAVE ACCENT?

That's true, that didn't occur to me. I updated the rest of the patch with this consideration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180106/9d72508e/attachment-0001.html>


More information about the webkit-unassigned mailing list