[Webkit-unassigned] [Bug 181309] New: Sandbox preprocessing should handle C++ comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 4 14:54:38 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181309

            Bug ID: 181309
           Summary: Sandbox preprocessing should handle C++ comments
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

The text preprocessing rules in WebKit's DerivedSources.make is now only used for processing our sandbox profiles. Sometimes the headers and availability macros included on macOS and iOS SDK's have spurious C++-style comments in them, which are not stripped out during preprocessing since we were telling clang to use C89 rules for preprocessing.

Instead, we should switch to C99 so that C++-style comments will get properly ignored, and we won't confuse the Sandbox library when it tries the read the finished file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180104/913d23d9/attachment.html>


More information about the webkit-unassigned mailing list