[Webkit-unassigned] [Bug 181138] [GTK] Crash destroying WebCore::FileMonitor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 2 15:31:18 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=181138

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330311|review?                     |review+
              Flags|                            |

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 330311
  --> https://bugs.webkit.org/attachment.cgi?id=330311
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=330311&action=review

I think the code changes are right.

It would be good to add a comment to document the thread-safety semantics of FileMonitor, since this has proven to be a tricky bit of code. Right now, it's not clear to the reader why the create/destroy operations need to be synchronous.

> Source/WebCore/platform/glib/FileMonitorGLib.cpp:60
> +    // The monitor can be destroyed in the work queue thread.
> +    if (&m_handlerQueue->runLoop() == &RunLoop::current())
> +        return;

Good catch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180102/76e8388c/attachment.html>


More information about the webkit-unassigned mailing list