[Webkit-unassigned] [Bug 183155] [FreeType] Color emojis in WebKitGTK+ for great justice

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 28 11:02:25 PST 2018


--- Comment #14 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334735
  --> https://bugs.webkit.org/attachment.cgi?id=334735
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334735&action=review

>>> Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:132
>>> +    }
>> I don't think this change is unrelated. It used to be live code, and now you've turned it into dead code, right? But very subtle dead code that most developers would not notice. So I would address bug #183210 in this same patch. Up to you, as long as you follow up promptly so that we don't forget about this.
> Why was it live code? I haven't changed anything here in behavior, it's just a cleanup.

Oops, I didn't look closely enough... I see this is different from your original patch. Yes, moving the declarations into the conditional tests is good. OK then!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180228/d16ca3d1/attachment-0001.html>

More information about the webkit-unassigned mailing list