[Webkit-unassigned] [Bug 183191] New: [webkitpy] Use shell=False to launch apache http server.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 27 16:53:01 PST 2018


            Bug ID: 183191
           Summary: [webkitpy] Use shell=False to launch apache http
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Basuke.Suzuki at sony.com
                CC: lforschler at apple.com

On LayoutTestApacheHttpd._run(), subprocess.Popen is used with `shell=True`. It is usually bad idea to pass shell=True, and there's no strong reason we should use shell=True in the code.

On the other hand, if we remove this, we get benefits like:
- no intermediate process which may ended up for security risk
- arguments are array, not a string, which is easy to manage.
- no need to quoting a lot.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180228/d29bb8d0/attachment-0001.html>

More information about the webkit-unassigned mailing list