[Webkit-unassigned] [Bug 183091] REGRESSION(r221514): [GTK] UI process crash in WebKit::WaylandCompositor::Surface::flushPendingFrameCallbacks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=183091

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #334595|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334595
  --> https://bugs.webkit.org/attachment.cgi?id=334595
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334595&action=review

Thanks

> Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:354
>                      auto* surface = static_cast<WaylandCompositor::Surface*>(wl_resource_get_user_data(resource));
> +                    WaylandCompositor::singleton().willDestroySurface(surface);
>                      delete surface;

Aha, so this is what I missed when staring at this bug the other day.

> Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp:571
> +            break;

You could equivalently use return instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180226/7215974e/attachment.html>