[Webkit-unassigned] [Bug 183051] [Curl] Cookie Database files are wrongfully getting deleted when the database is opened

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 23 14:01:36 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=183051

--- Comment #3 from Christopher Reid <chris.reid at sony.com> ---
(In reply to Don Olmstead from comment #2)
> Comment on attachment 334465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=334465&action=review
> 
> LGTM. I'm not sure how liberally we should be using auto or not.
> 
> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:166
> > +    FileSystem::PlatformFileHandle handle = FileSystem::openFile(getCorruptionMarkerPath(), FileSystem::FileOpenMode::Write);
> 
> Maybe auto here?

It looks like auto is used quite a bit with openFile in the FileSystem implementation files so it makes sense to use it here too.
I'll update the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180223/a7e7de17/attachment.html>


More information about the webkit-unassigned mailing list