[Webkit-unassigned] [Bug 183044] [WinCairo] Add WebKit Shared/win files for wincairo webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 23 12:49:27 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=183044

--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 334521
  --> https://bugs.webkit.org/attachment.cgi?id=334521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334521&action=review

Think this about ready to go. Just need to change that stale call.

> Source/WebKit/Shared/win/ProcessExecutablePathWin.cpp:62
> +#if ENABLE(DATABASE_PROCESS)
> +String executablePathOfDatabaseProcess()
> +{
> +    return findWebKitProcess("WebKitDatabaseProcess");
> +}
> +#endif

This is stale. There is no more Database Process its Storage Process. There's no ENABLE around it either.

String executablePathOfStorageProcess()
{
    return findWebKitProcess("WebKitStorageProcess");
}

> Source/WebKit/Shared/win/WebErrorsWin.cpp:41
> +    // FIXME: Need ChickenCat to include CFNetwork/CFURLError.h to get these values
> +    // Alternatively, we could create our own error domain/codes.

ChickenCat?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180223/0325df7d/attachment.html>


More information about the webkit-unassigned mailing list