[Webkit-unassigned] [Bug 182682] [WinCairo] WebKit2_C.h should be included for TestWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182682

--- Comment #7 from Yousuke Kimoto <Yousuke.Kimoto at sony.com> ---
(In reply to Yusuke Suzuki from comment #6)
> > Tools/TestWebKitAPI/config.h:64
> > +#if !PLATFORM(IOS) && !defined(BUILDING_JSCONLY__) && (!PLATFORM(WIN) || defined(BUILDING_WIN_CAIRO_WEBKIT))
> 
> Why doesn't `PLATFORM(WIN_CAIRO)` work?
"PLATFORM(WIN_CAIRO)" is used by both WinCairo WebKitLegacy and WebKit but WinCairo WebKit is an optional build mode for now.
In addition, the WinCairo's EWS configuration is dedicated for WebKitLegacy. The EWS will fail during building TestWebKitAPI due to including "WebKIt/WebKit2_C.h" which cannot be referred in the configuration.

To avoid such failure, "WebKit/WebKit2_C.h" should be included only for WinCairo WebKit. That is why "BUILDING_WIN_CAIRO_WEBKIT" is newly defined. We need the definition until when we establish to build WinCairo WebKit stably.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180223/7d206197/attachment.html>