[Webkit-unassigned] [Bug 182924] Potential privacy issue: DNS prefetching can be re-enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182924

--- Comment #14 from Milan Crha <mcrha at redhat.com> ---
Well, when I change it to something like this:

diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
index 0a5a1df61a..db08fb9b7a 100644
--- a/Source/WebCore/dom/Document.cpp
+++ b/Source/WebCore/dom/Document.cpp
@@ -5765,10 +5765,12 @@ void Document::initDNSPrefetch()

 void Document::parseDNSPrefetchControlHeader(const String& dnsPrefetchControl)
 {
-    if (equalLettersIgnoringASCIICase(dnsPrefetchControl, "on") && !m_haveExplicitlyDisabledDNSPrefetch) {
-        m_isDNSPrefetchEnabled = true;
+    if (!settings().dnsPrefetchingEnabled())
+        return;
+
+    // Let the page only disable prefetching, not enable it.
+    if (equalLettersIgnoringASCIICase(dnsPrefetchControl, "on"))
         return;
-    }

     m_isDNSPrefetchEnabled = false;
     m_haveExplicitlyDisabledDNSPrefetch = true;

then it's only written to m_haveExplicitlyDisabledDNSPrefetch, never read from it. That's why I removed it.

I think the change is that simple that you can correct it the way which prefer to you, I really do not care of credits, I only would like to have this included in the next stable release of WebKitGTK+ and not miss it due to nitpicks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180223/aebc3e7d/attachment.html>