[Webkit-unassigned] [Bug 183040] Separate paint and scroll offsets for RenderLayerBacking::m_scrollingContentsLayer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 22 12:49:42 PST 2018


Frédéric Wang (:fredw) <fred.wang at free.fr> changed:

           What    |Removed                     |Added
 Attachment #334454|                            |review?
              Flags|                            |

--- Comment #2 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 334454
  --> https://bugs.webkit.org/attachment.cgi?id=334454

View in context: https://bugs.webkit.org/attachment.cgi?id=334454&action=review

@Simon, Daniel: This patch just extracts the scrollOffset from offsetFromRender, but I'm not sure it is what was meant in the FIXME nor whether it's really an improvement... WDYT?

> Source/WebCore/rendering/RenderLayerBacking.cpp:2471
>          // but the repaint rect is computed without taking the scroll position into account (see shouldApplyClipAndScrollPositionForRepaint()).

I'm a bit confused by this comment. The first line (from Daniel, bug 125239) seems to say it is done because scrollOffset is included in the offsetFromRenderer in RenderLayerBacking::updateGeometry(), which actually happens on non-iOS platforms too and what I'm trying to remove here. The second line (from Simon, bug 159186) seems to say it is done because scrollPosition in applyCachedClipAndScrollPositionForRepaint (rather than shouldApplyClipAndScrollPositionForRepaint). So it does not seem we can get rid of this...

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180222/a7c85c03/attachment.html>

More information about the webkit-unassigned mailing list