[Webkit-unassigned] [Bug 182718] Set the appropriate AutoFill context for suggested passwords

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182718

--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 333903
  --> https://bugs.webkit.org/attachment.cgi?id=333903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333903&action=review

r=me (I'm not a WebKit2 owner though, so a WebKit2 owner should r+ if looks OK)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4035
> +        _firstResponderRequiresStrongPasswordAssistance = [inputDelegate _webView:_webView focusRequiresStrongPasswordAssistance:focusedElementInfo.get()];

Nit - it's a tiny bit weird for the thing that "requires strong password assistance" to be different between the ivar and the delegate method (firstResponder(…) vs. focus(…)). Could we choose one to make it consistent?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180216/49d74043/attachment.html>