[Webkit-unassigned] [Bug 162860] [GStreamer] Audio glitches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162860

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |calvaris at igalia.com

--- Comment #34 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 330461
  --> https://bugs.webkit.org/attachment.cgi?id=330461
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330461&action=review

It would be awesome if you could explain why this improves the situation as I see several things but I fail to understand why they work together.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:873
> -    // Emit a GST_EVENT_CUSTOM_DOWNSTREAM_STICKY event to let GStreamer know about the HTTP headers sent and received.
> +    // Emit a GST_EVENT_CUSTOM_DOWNSTREAM_STICKY event and message to let
> +    // GStreamer know about the HTTP headers sent and received.
>      GstStructure* httpHeaders = gst_structure_new_empty("http-headers");
> -    gst_structure_set(httpHeaders, "uri", G_TYPE_STRING, priv->originalURI.data(), nullptr);
> +    gst_structure_set(httpHeaders, "uri", G_TYPE_STRING, priv->originalURI.data(),
> +                      "http-status-code", G_TYPE_UINT, response.httpStatusCode(), nullptr);

You can keep this in a single line.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:888
> +    gst_element_post_message(GST_ELEMENT_CAST(src), gst_message_new_element(GST_OBJECT_CAST(src),
> +        gst_structure_copy(httpHeaders)));

ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180216/173ab93c/attachment-0001.html>