[Webkit-unassigned] [Bug 182757] [CMake][Ninja] Fails to compile TestWebCore due to missing WebCore's derived headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182757

--- Comment #8 from Fujii Hironori <Hironori.Fujii at sony.com> ---
(In reply to Fujii Hironori from comment #1)
> WEBKIT_MAKE_FORWARDING_HEADERS is using POST_BUILD event to copy derived
> headers.
> TestWebCore has a dependency to WebCore. But this is link-time dependency,
> it should be compile-time dependency.

I think the simplest solution is introducing an intermediate target between TestWebCore and WebCore.

diff --git a/Tools/TestWebKitAPI/PlatformGTK.cmake b/Tools/TestWebKitAPI/PlatformGTK.cmake
index 4aef6953cd1..013fa9301e9 100644
--- a/Tools/TestWebKitAPI/PlatformGTK.cmake
+++ b/Tools/TestWebKitAPI/PlatformGTK.cmake
@@ -105,6 +105,9 @@ add_executable(TestWebCore

 target_link_libraries(TestWebCore ${test_webcore_LIBRARIES})
 add_dependencies(TestWebCore ${ForwardingHeadersForTestWebKitAPI_NAME})
+add_custom_target(pre-TestWebCore)
+add_dependencies(TestWebCore pre-TestWebCore)
+add_dependencies(pre-TestWebCore WebCore)

 add_test(TestWebCore ${TESTWEBKITAPI_RUNTIME_OUTPUT_DIRECTORY}/WebCore/TestWebCore)
 set_tests_properties(TestWebCore PROPERTIES TIMEOUT 60)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180216/4d29e73d/attachment.html>