[Webkit-unassigned] [Bug 182757] [CMake][Ninja] Fails to compile TestWebCore due to missing WebCore's derived headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182757

--- Comment #6 from Don Olmstead <don.olmstead at sony.com> ---
(In reply to Fujii Hironori from comment #4)
> (In reply to Don Olmstead from comment #3)
> > What if instead of ${FRAMEWORK} being dependent on
> > ${FRAMEWORK}ForwardingHeaders it was flipped so that it was
> > ${FRAMEWORK}ForwardingHeaders was reliant on ${FRAMEWORK}. 
> 
> For example, WebKit links WebCore, and WebCore depends on
> WebCoreForwardingHeaders.
> Then, building WebKit triggers WebCoreForwardingHeaders.
> 
> > That way you
> > could target the derived sources in the list of headers.
> 
> I don't understand this sentence. What do you mean?
> 
> > It seems like this problem exists currently just the fact that WebCore has
> > so many headers that this sort of race condition can occur.
> 
> You are right.

This would be the dependencies.

WTF depends on nothing
WTFForwardingHeaders depends on WTF

JavaScriptCore depends on WTF and WTFForwardingHeaders
JavaScriptCoreForwardingHeaders depends on JavaScriptCore

WebCore depends on WTF, WTFForwardingHeaders, JavaScriptCore, and JavaScriptCoreForwardingHeaders
WebCoreForwardingHeaders depends on WebCore

If its a dependency on WebCore and WebCore produces Settings.h then within the CMake we would append the derived sources headers.

list(APPEND WebCore_PRIVATE_FRAMEWORK_HEADERS
    ${DERIVED_SOURCES_WEBCORE_DIR}/Settings.h
    ....
)

Correct me if I'm wrong but wouldn't ninja be happy at that point?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180215/75d6e89b/attachment.html>