[Webkit-unassigned] [Bug 182698] Add C SPI for support of Website Data Store in Website Policies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182698

--- Comment #9 from Maureen Daum <mdaum at apple.com> ---
Comment on attachment 333623
  --> https://bugs.webkit.org/attachment.cgi?id=333623
patch (referring to "C API" instead of "Legacy WebKit")

View in context: https://bugs.webkit.org/attachment.cgi?id=333623&action=review

>> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:54
>> +        RELEASE_ASSERT_WITH_MESSAGE(sessionID.isEphemeral() || sessionID == PAL::SessionID::defaultSessionID(), "WebsiteDataStore must be nil, default, or non-persistent.");
> 
> The wording here isn't quite right, since "default" and "non-persistent" apply to the data store's session, not the data store itself. Also, "nil" isn't the right term in C.

Changed to "If WebsitePolicies specifies a WebsiteDataStore, the data store's session must be default or non-persistent."

>> Source/WebKit/UIProcess/API/C/WKFramePolicyListener.cpp:55
>> +        RELEASE_ASSERT_WITH_MESSAGE(toImpl(policyListenerRef)->isMainFrame(), "WebsiteDataStore must be nil for subframe navigations.");
> 
> Same comment about "nil".

Changed to "WebsitePolicies cannot specify a WebsiteDataStore for subframe navigations."

>> Source/WebKit/UIProcess/WebFrameListenerProxy.h:50
>> +    bool isMainFrame();
> 
> This should be const-qualified.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180214/11f7e1d9/attachment.html>