[Webkit-unassigned] [Bug 182729] New: run-jsc-stress-tests - skip a test if any of the run commands evals to skip

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 13 07:03:35 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182729

            Bug ID: 182729
           Summary: run-jsc-stress-tests - skip a test if any of the run
                    commands evals to skip
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tpopela at redhat.com
                CC: lforschler at apple.com, mark.lam at apple.com

Imagine, that we have the following run command in the beginning of some stress tests:

//@ defaultNoEagerRun

now, we don't want to run this test if JIT is disabled (because the test is failing there). What we could do is:

//@ if $jitTests then defaultNoEagerRun else skip end

but I personally don't like it.. Better would be to use:

//@ skip if not $jitTests
//@ defaultNoEagerRun

but this does not work right now, because Tools/Scripts/run-jsc-stress-tests will analyse the first line, skip the run as expected, but then will start to analyse the second line and will schedule a run. We should skip further analysis if the test is skipped.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180213/e1f32df9/attachment.html>


More information about the webkit-unassigned mailing list