[Webkit-unassigned] [Bug 182427] Add a way to check if a host is an IP address

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 9 01:06:20 PST 2018


--- Comment #36 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Wenson Hsieh from comment #35)
> (In reply to Carlos Alberto Lopez Perez from comment #33)
> > (In reply to Matt Lewis from comment #32)
> > > Reverted r228261 for reason:
> > > 
> > > This broke an internal build
> > > 
> > > Committed r228282: <https://trac.webkit.org/changeset/228282>
> > 
> > Can you provide more info about what broke ? logs, etc
> Sorry for the delay — the original revision (r228261) caused an internal
> builder to start failing in PublicSuffixMac.mm because it could not find
> decodeHostName. This appears to be declared in WebCoreNSURLExtras.h, but the
> line where we #import "WebCoreNSURLExtras.h" was removed from
> PublicSuffixMac.mm in the original patch.
> I can take a closer look tomorrow, but hopefully this helps a bit!

Thanks for the details. It seems to me that simply adding the missing include to fix the internal build is less effort than rolling out the two patches again, but still, I'll submit a new patch with the missing include.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180209/10cd3e4a/attachment.html>

More information about the webkit-unassigned mailing list