[Webkit-unassigned] [Bug 182622] New: [MIPS] Do not hardcode usage of libatomic, use detection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 8 13:29:33 PST 2018


            Bug ID: 182622
           Summary: [MIPS] Do not hardcode usage of libatomic, use
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

After the patch for bug #182610 on MIPS libatomic is unconditionally
added to the libraries linked into JSC. Instead, it would be desirable
to detect whether it's needed and add it only in that case.

There is already a check for libatomic at “Source/WebKit/CMakeLists.txt”
(lines starting at 780) which could be reused. Probably the best course
of action is to:

  - Move the check into a new file e.g. “Source/cmake/CheckLibatomic.cmake”
  - Add “include(CheckLibatomic)” into “Source/cmake/WebKitCommon.cmake”
  - Use the result from the checks in all places where it's needed (for
    now that would be “Source/{JavaScriptCore,WebKit}/CMakeLists.txt”)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180208/7e2ae299/attachment.html>

More information about the webkit-unassigned mailing list