[Webkit-unassigned] [Bug 182479] [Win] Fix MSVC's treating __attribute__((warn_unused_result))

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182479

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |achristensen at apple.com

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 333074
  --> https://bugs.webkit.org/attachment.cgi?id=333074
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333074&action=review

> Source/WebKit/UIProcess/API/cpp/WKRetainPtr.h:245
> +#if !COMPILER(MSVC)

We usually try to put the positive first, so this would be #if COMPILER(MSVC)
But you can't use COMPILER here because this header is part of the API.  Elsewhere in the API we've done #if defined(WIN32) || defined(_WIN32), but maybe we should check _MSC_VER instead for people using clang on windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180206/6729c328/attachment-0001.html>