[Webkit-unassigned] [Bug 182489] New: Temporarily replace RELEASE_ASSERT with ASSERT in FrameLoader::stopAllLoaders.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182489

            Bug ID: 182489
           Summary: Temporarily replace RELEASE_ASSERT with ASSERT in
                    FrameLoader::stopAllLoaders.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: pvollan at apple.com

On trunk, we currently have a release assert that asserts that scripts are allowed when calling FrameLoader::stopAllLoaders. This is correct since stopAllLoaders might dispatch events. We should continue to have the release assert in trunk, because we should catch when this happens. However, there still might be cases where the assert fails, but the backtrace will turn out to be one where scripting could be allowed. The release assert in trunk will help us catch these cases. On the branch, however, we should avoid crashing in these cases, and replace the release assert with a debug assert. If approved, this patch should only land on a branch, not on trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180205/2ddfa29c/attachment.html>