[Webkit-unassigned] [Bug 182427] Add a way to check if a host is an IP address

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 2 10:18:31 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182427

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #332963|review?                     |review+
              Flags|                            |

--- Comment #10 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 332963
  --> https://bugs.webkit.org/attachment.cgi?id=332963
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332963&action=review

> Source/WebCore/platform/URL.cpp:1042
> +    // Assume that any host that ends with a digit is trying to be an IP address.
> +    return !host.isEmpty() && isASCIIDigit(host[host.length() - 1]);

It's awful that this was ever used, but it's good that this is being used on fewer platforms.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180202/6ea61fcb/attachment.html>


More information about the webkit-unassigned mailing list