[Webkit-unassigned] [Bug 182188] REGRESSION(r225868): Release assert when removing an SVGUseElement from Document::m_svgUseElements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 1 01:55:27 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=182188

--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Said Abou-Hallawa from comment #5)
> Comment on attachment 332456 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332456&action=review
> 
> What exactly is not desirable in this patch? Do you consider using
> HashSet<>::contains() to be a lot more expensive than accessing a data
> member?

Yes. It's considerably more expensive. Also, rewriting the way hash map works completely isn't a way to address this crash we don't even have a test case for.

We really need a more thorough analysis of what might be happening instead of rewriting the entire thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180201/87075ba2/attachment.html>


More information about the webkit-unassigned mailing list