[Webkit-unassigned] [Bug 193056] New: Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 29 05:33:35 PST 2018


            Bug ID: 193056
           Summary: Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: andersca at apple.com, darin at apple.com,
                    dbates at webkit.org, mitz at webkit.org, mjs at apple.com

Prefer RetainPtr<NSObject> to RetainPtr<NSObject *> because:
- It was the original intent based on Macieij's comment from r16987.
- The vast majority of RetainPtr<> use in WebKit already omits the '*' operator for NS types.  (Yay consistency!)
- We can write a style checker rule to enforce it.
- We can make adoptNS() and retainPtr() create the correct types using C++ template metaprogramming.

Note that RetainPtr<NSObject *> still works as it did before (and tests have been added to verify that it works with RetainPtr<NSObject>).

This change simply formalizes the preference for RetainPtr<NSObject> over RetainPtr<NSObject *>.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181229/5d3773f7/attachment.html>

More information about the webkit-unassigned mailing list