[Webkit-unassigned] [Bug 182689] Unified builds broke ycm autocompletion using compilation databases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=182689

--- Comment #22 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
(In reply to Carlos Eduardo Ramalho from comment #21)
> (In reply to Carlos Eduardo Ramalho from comment #20)
> > (In reply to Yusuke Suzuki from comment #19)
> > > Interesting! Now I think the good way to fix this issue is adding an option
> > > disabling unified builds (which makes compile_commands.json expected one).
> > 
> > Hmm indeed! This might really be the way to go. Also, to get the
> > compile_commands.json file one does not need to compile the project, but
> > only "generate" or "configure" it with CMake e.g. with 
> 
> Correction: actually we still need to build the project in WebKit because we
> need to resolve the ForwardingHeaders.

Right.

> 
> For developing, disabling unified sources might be OK because usually what
> will matter is sequential builds times and it should be improved by
> disabling unified sources actually.

No. It significantly worse the build time. I think unified builds should be enabled by default.
And we should have the option disabling it.
I uploaded the patch for that option.
https://bugs.webkit.org/show_bug.cgi?id=193045

> 
> (On a side note, sequential builds will be faster even with unified sources
> after bug 192391 lands.)
> 
> I was able to disable unified sources and should upload a patch soon with
> the option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181228/7c41fa06/attachment.html>