[Webkit-unassigned] [Bug 193036] [FreeType] Restore conditional compilation logic for recent HarfBuzz refactoring

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=193036

--- Comment #3 from Jim Mason <jmason at ibinx.com> ---
(In reply to Michael Catanzaro from comment #2)
> Jim,
> what port are you building, and with what build flags?
> 
> Hey Don, here's another one. ENABLE(OPENTYPE_MATH) is not a valid feature
> flag, but it's being used throughout several files under
> platform/graphics/opentype. It's defined only in OptionsGTK.cmake using cpp
> flags

Indeed, OPENTYPE_MATH is being set for me automatically, as I am building using an older version of HarfBuzz.  OptionsGTK.cmake sets the flag if HarfBuzz is older than version 1.3.3, and I am using 1.0.6.

When the code was in OpenTypeMathData, it was compiled according to the construct:

    #if ENABLE(OPENTYPE_MATH)
    #elif USE(HARFBUZZ)
    ..code that was refactored lived here..

Thus, the code was compiled only if USE(HARFBUZZ) && !ENABLE(OPENTYPE_MATH).  Conditioning compilation on !ENABLE(OPENTYPE_MATH) is necessary, as the code references an API that is not exposed by the earlier versions of HarfBuzz.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181226/199ad654/attachment.html>