[Webkit-unassigned] [Bug 192935] clang-tidy: Could remove up to 32 padding bytes in class JSC::BytecodeGenerator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 24 04:07:49 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=192935

Yusuke Suzuki <yusukesuzuki at slowstart.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yusukesuzuki at slowstart.org

--- Comment #5 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
(In reply to Saam Barati from comment #4)
> (In reply to David Kilzer (:ddkilzer) from comment #3)
> > I'm just going to move this to RESOLVED/WONTFIX.  Not sure it's worth doing
> > based on the size of the class.
> 
> Agreed. This class is only ever stack allocated, too. And pretty
> infrequently at that. So it’s probably not worth much to do this.

I think this is heap allocated by using std::make_unique<> (but yeah right, it is not frequently, and immediately discarded just after generating the bytecode)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181224/a2543f6d/attachment-0001.html>


More information about the webkit-unassigned mailing list