[Webkit-unassigned] [Bug 180373] Web Inspector: Crashes seen under Inspector::ScriptCallFrame::~ScriptCallFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=180373

--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to Simon Fraser (smfr) from comment #7)
> Comment on attachment 357982 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=357982&action=review
> 
> > Source/JavaScriptCore/inspector/AsyncStackTrace.cpp:172
> > +    RefPtr<AsyncStackTrace> protect(lastUnlockedAncestor->m_parent);
> >      auto* sourceNode = lastUnlockedAncestor->m_parent.get();
> 
> Why not just
>   RefPtr<AsyncStackTrace> sourceNode = lastUnlockedAncestor->m_parent; ?

Okay will do. It has a bit more ref churn in the loop but is ultimately safer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181221/a19ae8da/attachment.html>