[Webkit-unassigned] [Bug 192980] Eliminate line-breaks and disappear of list marker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192980

--- Comment #3 from cathiechen <cathiechen at igalia.com> ---
Comment on attachment 357937
  --> https://bugs.webkit.org/attachment.cgi?id=357937
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357937&action=review

>> Source/WebCore/rendering/RenderListItem.h:65
>> +    bool needBlockDirectionAlign() { return m_needBlockDirectionAlign; }
> 
> This should be const.

done

>> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:79
>> +        return;
> 
> You probably want to check this before cloning.

done

>> Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp:170
>> +                else
> 
> The indenting is weird here, does check-webkit-style say anything?

Nope, it made me delete the one-line braces at first.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181221/708cfc16/attachment.html>