[Webkit-unassigned] [Bug 192943] Moving non-critical initializations to a parallel thread can speed up process launch time by 15%.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 13:39:37 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=192943

--- Comment #6 from Suresh Koppisetty <skoppisetty at apple.com> ---
Comment on attachment 357845
  --> https://bugs.webkit.org/attachment.cgi?id=357845
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357845&action=review

>>> Source/WebKit/WebProcess/WebProcess.h:471
>>> +    dispatch_queue_t m_internalQueue;
>> 
>> Could we use a WTF::WorkQueue?
> 
> You could also use OSObjectPtr<dispatch_queue_t>. We just like to avoid explicit memory management in WebKit.

Using OSObjectPtr<dispatch_queue_t>. Thanks for the suggestions.

>> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:368
>> +    dispatch_async(m_internalQueue, ^{
> 
> WebProcess::updateProcessName() would have to use the same (serial) queue, otherwise, the call to _RegisterApplication() may happen *after* we've tried to set the process name and setting the process name would fail.

Righ, all of them happen in m_internalQueue serial queue. Changing comments a bit to convey the same message.

>> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:421
>> +    dispatch_release(m_internalQueue);
> 
> Then we wouldn't need this.

Yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181220/cd41385c/attachment.html>


More information about the webkit-unassigned mailing list