[Webkit-unassigned] [Bug 192947] New: Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192947

            Bug ID: 192947
           Summary: Web Inspector: Keyboard shortcut for settings tab too
                    greedy on non-US keyboards
           Product: WebKit
           Version: Safari 12
          Hardware: Macintosh
                OS: All
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ljt at meidosem.com
                CC: inspector-bugzilla-changes at group.apple.com

The Inspector, in WebInspectorUI/UserInterface/Models/KeyboardShortcut.js, handles keyboard shortcuts through the deprecated "keyCode" attribute from the onkeydown event.
On non-US keyboards, this attribute is unreliable (see https://hacks.mozilla.org/2017/03/internationalize-your-keyboard-controls/). 

For instance:
On a French MacBook Pro keyboard, the "<" key (between left shift and W, no equivalent key on an QWERTY keyboard) has the same keyCode (188) as the Comma key. (On a Turkish keyboard, the ö key also has the 188 keyCode.) On some systems, Cmd-< is used to cycle between windows (the equivalent to Cmd-` on US layouts). French users hitting the cycle shortcut out of muscle memory end up on the Inspector's setting page.

Possible solutions:
The "key" attribute on the onkeydown event returns the proper key values for every keyboard type. KeyboardShortcut.js could be modified as such.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181220/f540053e/attachment-0001.html>