[Webkit-unassigned] [Bug 192935] New: clang-tidy: Could remove up to 32 padding bytes in class JSC::BytecodeGenerator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192935

            Bug ID: 192935
           Summary: clang-tidy: Could remove up to 32 padding bytes in
                    class JSC::BytecodeGenerator
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org

Running `clang-tidy -header-filter=.* -checks='-*,clang-analyzer-optin.performance.*' ...` on JavaScriptCore source files found unneeded padding bytes in the JSC::BytecodeGenerator class.

Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:362:11: warning: Excessive padding in 'class JSC::BytecodeGenerator' (39 padding bytes, where 7 is optimal). 
Optimal fields order: 
m_scopeNode, 
m_codeBlock, 
m_scopeRegister, 
m_topMostScope, 
m_argumentsRegister, 
m_lexicalEnvironmentRegister, 
m_generatorRegister, 
m_emptyValueRegister, 
m_globalObjectRegister, 
m_newTargetRegister, 
m_isDerivedConstuctor, 
m_linkTimeConstantRegisters, 
m_arrowFunctionContextLexicalEnvironmentRegister, 
m_promiseCapabilityRegister, 
m_completionTypeRegister, 
m_completionValueRegister, 
m_currentFinallyContext, 
m_generatorFrameSymbolTable, 
m_restParameter, 
m_vm, 
m_lexicalScopeStack, 
m_TDZStack, 
m_varScopeLexicalScopeStackIndex, 
m_switchContextStack, 
m_forInContextStack, 
m_tryContextStack, 
m_functionsToInitialize, 
m_tryRanges, 
m_lastInstruction, 
m_catchesToEmit, 
m_writer, 
m_functions, 
m_localRegistersForCalleeSaveRegisters, 
m_constantPoolRegisters, 
m_calleeLocals, 
m_parameters, 
m_labels, 
m_labelScopes, 
m_controlFlowScopeStack, 
m_tryData, 
m_functionOffsets, 
m_identifierMap, 
m_jsValueMap, 
m_stringMap, 
m_bigIntMap, 
m_templateObjectDescriptorMap, 
m_staticPropertyAnalyzer, 
m_finallyDepth, 
m_localScopeDepth, 
m_codeType, 
m_yieldPoints, 
m_generatorFrameSymbolTableIndex, 
m_nextConstantOffset, 
m_lastOpcodeID, 
m_ignoredResultRegister, 
m_thisRegister, 
m_calleeRegister, 
m_shouldEmitDebugHooks, 
m_needToInitializeArguments, 
m_usesExceptions, 
m_expressionTooDeep, 
m_isBuiltinFunction, 
m_usesNonStrictEval, 
m_inTailPosition, 
m_needsToUpdateArrowFunctionContext, 
m_derivedContextType, 
consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding]
    class BytecodeGenerator {
          ^

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181220/46c39aad/attachment.html>