[Webkit-unassigned] [Bug 192913] New: UserMedia test should use WKPageNavigationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192913

            Bug ID: 192913
           Summary: UserMedia test should use WKPageNavigationClient
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: achristensen at apple.com, lforschler at apple.com,
                    youennf at gmail.com

r239167 "On page close, WebPage::m_userMediaPermissionRequestManager is nullified too early" introduced a deprecation warning:

[452/530] Building CXX object Tools/TestWebKitAPI/C...keFiles/TestWebKit.dir/Tests/WebKit/UserMedia.cpp.o
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp: In member function ‘virtual void TestWebKitAPI::WebKit_OnDeviceChangeCrash_Test::TestBody()’:
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
                                                                  ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~
../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:139:66: warning: ‘void WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase*)’ is deprecated: use WKPageSetPageNavigationClient [-Wdeprecated-declarations]
     WKPageSetPageLoaderClient(webView2.page(), &loaderClient.base);
                                                                  ^
In file included from DerivedSources/ForwardingHeaders/WebKit/WKPage.h:1,
                 from ../../Source/WebKit/UIProcess/API/C/WebKit2_C.h:53,
                 from DerivedSources/ForwardingHeaders/WebKit/WebKit2_C.h:1,
                 from ../../Tools/TestWebKitAPI/config.h:49,
                 from ../../Tools/TestWebKitAPI/Tests/WebKit/UserMedia.cpp:20:
../../Source/WebKit/UIProcess/API/C/WKPage.h:228:16: note: declared here
 WK_EXPORT void WKPageSetPageLoaderClient(WKPageRef page, const WKPageLoaderClientBase* client) WK_C_API_DEPRECATED_WITH_REPLACEMENT(WKPageSetPageNavigationClient, macosx(WK_MAC_TBA));
                ^~~~~~~~~~~~~~~~~~~~~~~~~

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181220/d9eec975/attachment.html>