[Webkit-unassigned] [Bug 192736] HTTPS Upgrade: Use full sqlite upgrade list

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 14:47:16 PST 2018


Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
 Attachment #357727|review?                     |review+
              Flags|                            |

--- Comment #22 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357727
  --> https://bugs.webkit.org/attachment.cgi?id=357727

View in context: https://bugs.webkit.org/attachment.cgi?id=357727&action=review

r=me with suggestion.

> Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:68
> +        ASSERT(isDatabaseOpen);

I think we should return early if !isDatabaseOpen in release so that m_didSetupCompleteSuccessfully never gets set to true.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181219/4c2684c7/attachment.html>

More information about the webkit-unassigned mailing list