[Webkit-unassigned] [Bug 191976] [FreeType] Color emoji not properly supported

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 11:29:08 PST 2018


Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |aperez at igalia.com

--- Comment #13 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 357679
  --> https://bugs.webkit.org/attachment.cgi?id=357679

View in context: https://bugs.webkit.org/attachment.cgi?id=357679&action=review

Informal review: A couple of nits, patch looks good overall but I am not an expert
in fonts so it would be good to have an r+ by someone who knows better, like Myles :)

> Source/WebCore/ChangeLog:18
> +        (WebCore::characterSequenceIsEmoji): Checke whether the character sequence is an emoji.

Typo: Checke → Check

> Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:67
> +        if (nextCharacter == 0xFE0F) {

Maybe it would be good to give a name to this constant instead of leaving
magic numbers around in the middle of the function.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181219/9cf34ec5/attachment.html>

More information about the webkit-unassigned mailing list