[Webkit-unassigned] [Bug 192841] [WPE][GTK] Purge use of g_assert() under TestWebKitAPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 19:47:51 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=192841

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|webkit-unassigned at lists.web |mcatanzaro at igalia.com
                   |kit.org                     |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Ah, I thought I was done with this, but hit a problem and won't have a patch tonight:

../../Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:44:61: error: invalid conversion from ‘WebKitUserContentManager*’ {aka ‘_WebKitUserContentManager*’} to ‘guint64’ {aka ‘long unsigned int’} [-fpermissive]
     g_assert_cmphex(webkit_web_view_get_user_content_manager(webView1.get()), ==, userContentManager1.get());
                                                             ^

The macro is defeated by C++ so we'll need to use g_assert_true() or write our own macro that does the casts for us.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181219/70e8941c/attachment.html>


More information about the webkit-unassigned mailing list