[Webkit-unassigned] [Bug 192841] New: [WPE][GTK] Purge use of g_assert() under TestWebKitAPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192841

            Bug ID: 192841
           Summary: [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com
                CC: bugs-noreply at webkitgtk.org, lforschler at apple.com

The documentation of g_assert() says:

"""
The macro can be turned off in final releases of code by defining G_DISABLE_ASSERT when compiling the application, so code must not depend on any side effects from expr . Similarly, it must not be used in unit tests, otherwise the unit tests will be ineffective if compiled with G_DISABLE_ASSERT. Use g_assert_true() and related macros in unit tests instead.
"""

There are separate g_assert_*() macros for use in tests, which we use inconsistently currently. Use them always. This probably wasn't the best use of my time today, but it's been annoying me for a while and makes sense to do. We'll get nicer error messages now when tests fail.

The documentation also says not to use g_assert_not_reached() in tests, but there is no good replacement for that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181219/8760181e/attachment.html>