[Webkit-unassigned] [Bug 192612] HTTPS Upgrade: Scripts / preprocessing necessary to create new database in future

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 08:36:56 PST 2018


--- Comment #16 from Andy Estes <aestes at apple.com> ---
Comment on attachment 357362
  --> https://bugs.webkit.org/attachment.cgi?id=357362

View in context: https://bugs.webkit.org/attachment.cgi?id=357362&action=review

>>> Source/WebKit/WebKit.xcodeproj/project.pbxproj:3405
>>> +		587743A421C30AD800AE9084 /* HTTPSUpgradeList.db */ = {isa = PBXFileReference; lastKnownFileType = file; name = HTTPSUpgradeList.db; path = DerivedSources/WebKit2/HTTPSUpgradeList.db; sourceTree = BUILT_PRODUCTS_DIR; };
>> Something seems wrong here. Usually sourceTree would be "<group>" and path would just contain the file name. There's a way to fix this in the Xcode UI (or I think you could fix it by hand).
> This matches how other files are in the DerivedSources folder. For example, see NetworkSocketStreamMessageReceiver.cpp  just below this line.

Oh I see. Well, it matches some but not all other files in DerivedSources. Since the file's group (Derived Sources) is relative to BUILT_PRODUCTS_DIR, I think it's cleaner to make this file be relative to "<group>" and then have the path just be the file name.

Anyway, since we aren't consistent here then this is ok as-is.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181218/3caff52e/attachment.html>

More information about the webkit-unassigned mailing list