[Webkit-unassigned] [Bug 192805] [Win] Fix the wrong return value checking of ScriptItemize in UniscribeController::itemizeShapeAndPlace

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192805

--- Comment #1 from Fujii Hironori <Hironori.Fujii at sony.com> ---
FAILED macro | Microsoft Docs
https://docs.microsoft.com/en-us/windows/desktop/api/winerror/nf-winerror-failed

> #define FAILED(hr) (((HRESULT)(hr)) < 0)

FAILED(rc) is always false.

ScriptItemize function | Microsoft Docs
https://docs.microsoft.com/en-us/windows/desktop/api/usp10/nf-usp10-scriptitemize

> The function returns E_INVALIDARG if pwcInChars is set to NULL, cInChars is 0, pItems is set to NULL, or cMaxItems < 2.

If I understand the code correctly, ScriptItemize never returns E_INVALIDARG in above code. There is no way to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181218/6d627652/attachment-0001.html>