[Webkit-unassigned] [Bug 192750] New: Simple line layout: space not added when joining text boxes for inner text in some cases

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=192750

            Bug ID: 192750
           Summary: Simple line layout: space not added when joining text
                    boxes for inner text in some cases
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: Gtk, LayoutTestFailure
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: bfulgham at webkit.org, koivisto at iki.fi,
                    simon.fraser at apple.com, zalan at apple.com

Created attachment 357429

  --> https://bugs.webkit.org/attachment.cgi?id=357429&action=review

Test case

Several tests started to fail for GTK+ port when we switched to always use complex text. See for example:

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r239206%20(9103)/fast/css/getComputedStyle/computed-style-font-family-pretty-diff.html

Note that the only difference is that the expected output doesn't have a space between "Firefox behavior." and "stopPropagation called." This is because the simple line layout code path is taken in TextIterator::handleTextNode(). When forcing complex text, that path is not taken and a space is added, which is the correct behavior I guess. I've created a simple test to check this, see the attached file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181217/4f2a7826/attachment.html>