[Webkit-unassigned] [Bug 171632] [Tools] Add support for clang-tidy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171632

--- Comment #14 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to Don Olmstead from Bug 192710 Comment #6)
> Do we have any ideas on what clang-tidy rules should be run? I'd like to run
> it more often over the code base to see what it finds.
> 
> Fujii is working on getting clang-cl working on Windows at which point we
> should be able to run it more.
> 
> https://bugs.webkit.org/show_bug.cgi?id=171632 is a tracking bug for more
> general support for it in WebKit.

For the recent clang-tidy bugs I've been filing and fixing, I've been focusing only on performance-* warnings (excluding performance-noexcept-* warnings since WebKit compiles with C++ exceptions disabled by default):

clang-tidy -header-filter=.* -checks='-*,performance-*,-performance-noexcept-*' ...

I haven't tried any other checks yet.

My original intent was to find unnecessary object copies, specifically in for loops, but there were lots of other easy fixes to prevent object copies as well.

I wrote a hacky Perl script that parses xcodebuild output and then runs clang-tidy on the result to find these issues (in addition to building my own local copy of llvm/clang since Xcode's toolchains don't come with clang-tidy).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181215/9064922c/attachment.html>